feat(inc): Add index to GroupOpenPeriod data jsonfield #97534
Merged
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
commented
Aug 8, 2025
| @@ -73,6 +73,10 @@ class Meta: | |||
| indexes = ( | |||
| # get all open periods since a certain date | |||
| models.Index(fields=("group", "date_started")), | |||
| models.Index( | |||
| models.F("data__pending_incident_detector_id"), | |||
| name="data__pend_inc_detector_id_idx", | |||
There was a problem hiding this comment.
name is required and it's limited to 30 chars so I did the best I could here
ceorourke
force-pushed
the
ceorourke/groupopenperiod-index-jsonfield
branch
from
b9c0373 to
aab255c
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Create index data__pend_inc_detector_id_idx on F(data__pending_incident_detector_id) on model groupopenperiod
--
CREATE INDEX CONCURRENTLY "data__pend_inc_detector_id_idx" ON "sentry_groupopenperiod" ((("data" -> 'pending_incident_detector_id'))); |
vgrozdanic
reviewed
Aug 11, 2025
| # is a schema change, it's completely safe to run the operation after the code has deployed. | ||
| # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
|
||
| is_post_deployment = False |
There was a problem hiding this comment.
This should be post-deployment migration, as this table has >260M rows, and adding index will probably time out if we do it as in-deploy migration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97534 +/- ##
========================================
Coverage 80.62% 80.62%
========================================
Files 8560 8560
Lines 376889 377106 +217
Branches 24538 24538
========================================
+ Hits 303870 304048 +178
- Misses 72649 72688 +39
Partials 370 370 |
wedamija
approved these changes
Aug 11, 2025
ceorourke
added a commit
that referenced
this pull request
Aug 12, 2025
Redo of #96221 after [adding an index](#97534) to the `GroupOpenPeriod`'s `data` column on `pending_incident_detector_id` which should hopefully not result in [the error](https://sentry.sentry.io/issues/6799376702/) anymore. There are no changes to this PR from the original one. --------- Co-authored-by: Snigdha Sharma <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
#96221 had to be reverted due to https://sentry.sentry.io/issues/6799376702 so we thought adding an index on `GroupOpenPeriod`'s `data` jsonfield to the frequently looked up `pending_incident_detector_id` key would help speed things up.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
Redo of #96221 after [adding an index](#97534) to the `GroupOpenPeriod`'s `data` column on `pending_incident_detector_id` which should hopefully not result in [the error](https://sentry.sentry.io/issues/6799376702/) anymore. There are no changes to this PR from the original one. --------- Co-authored-by: Snigdha Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96221 had to be reverted due to https://sentry.sentry.io/issues/6799376702 so we thought adding an index on
GroupOpenPeriod'sdatajsonfield to the frequently looked uppending_incident_detector_idkey would help speed things up.